Skip to content

refactor(sonar): fix cpp:S125, cpp:S3261, cpp:S995, cpp:S6009, cpp:S3574, and cpp:S1186 - #265

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/multiple-fixes
Jun 9, 2026
Merged

refactor(sonar): fix cpp:S125, cpp:S3261, cpp:S995, cpp:S6009, cpp:S3574, and cpp:S1186#265
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/multiple-fixes

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes sonar issues cpp:S125, cpp:S3261, cpp:S995, cpp:S6009, cpp:S3574, and cpp:S1186

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher changed the title refactor(sonar): fix cpp:S125, cpp:S3261, cpp:S995, cpp:S6009, cpp:S3… refactor(sonar): fix cpp:S125, cpp:S3261, cpp:S995, cpp:S6009, cpp:S3574, and cpp:S1186 Jun 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (0342fc8) to head (36bd0eb).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   92.97%   92.96%   -0.01%     
==========================================
  Files          35       35              
  Lines        2276     2275       -1     
  Branches     1111     1110       -1     
==========================================
- Hits         2116     2115       -1     
  Misses         44       44              
  Partials      116      116
Flag Coverage Δ
Linux 92.68% <ø> (ø)
Windows-AMD64 91.54% <92.85%> (+0.03%) ⬆️
Windows-ARM64 64.95% <71.42%> (+0.11%) ⬆️
macOS 72.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e/display_device/windows/win_api_layer_interface.h 100.00% <ø> (ø)
src/windows/settings_manager_apply.cpp 98.70% <ø> (ø)
src/windows/settings_manager_revert.cpp 98.38% <ø> (ø)
src/windows/settings_utils.cpp 95.61% <100.00%> (ø)
src/windows/win_api_layer.cpp 75.59% <100.00%> (ø)
src/windows/win_api_utils.cpp 99.57% <100.00%> (-0.01%) ⬇️
src/windows/win_display_device_modes.cpp 99.13% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0342fc8...36bd0eb. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit ce6f7b9 into master Jun 9, 2026
22 checks passed
@ReenigneArcher
ReenigneArcher deleted the refactor/sonar/multiple-fixes branch June 9, 2026 23:35
@ReenigneArcher ReenigneArcher added this to the sonar milestone Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

sonar

Development

Successfully merging this pull request may close these issues.

1 participant

@ReenigneArcher